[native_assets_builder] Use package:files FileSystem abstraction
#1825
Conversation
mkustermann
force-pushed
the
package-file
branch
from
59f08d1 to
1ee0111
Compare
There was a problem hiding this comment.
Please mention #90 in the PR description.
Unfortunately, almost of our tests also require process runs, so we can't change any of our tests to use the virtual file system.
Anyway, this is a step in that direction, so LGTM!
There's in more import in pkgs/native_assets_builder/lib/src/utils/run_process.dart which can get a show xxx to ensure we don't see any of the dart:io File/Directory types anywhere in lib/src.
pkgs/native_assets_builder/lib/src/dependencies_hash_file/dependencies_hash_file.dart
Show resolved
Hide resolved
pkgs/native_assets_builder/lib/src/package_layout/package_layout.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/lib/src/package_layout/package_layout.dart
Outdated
Show resolved
Hide resolved
Done.
One step at a time.
Done. |
|
Thanks @mkustermann ! |
The main motivation for this change is to make
package:native_assets_buildercleanly usable in flutter tools. Right now flutter tools operates on aFileSystemand checks whether.dart_tool/package_config.jsonexists using thatFileSystembut then reads the file with this packagag's code which usesdart:io.This inconsistency causes issues in flutter tools. Using
package:fileshould solve this and would alsoallow injecting mocks. To be fully mockable the implementation would also need to make process invocations
mockable via
package:process. That's a future task.See also #90